Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix vertical scrolling in data menu #1491

Merged
merged 1 commit into from
Jul 15, 2022
Merged

fix vertical scrolling in data menu #1491

merged 1 commit into from
Jul 15, 2022
+4 −2

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jul 14, 2022 •
edited by pllim
Loading

Description

This pull request fixes a UI bug in the data menu where the "x" icon had position absolute and so didn't scroll with the data entries.

Before:

Screen.Recording.2022-07-14.at.3.52.43.PM.mov

After:

Screen.Recording.2022-07-14.at.3.41.00.PM.mov

Fixes #

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added bug Something isn't working UI/UX😍 trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Jul 14, 2022
@kecnry kecnry added this to the 2.8 milestone Jul 14, 2022
@pllim
Copy link
Contributor

pllim commented Jul 14, 2022

Is this fixes a bug in released feature, should have a change log?

pllim
pllim approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change log aside, LGTM. Thanks!

@codecov
Copy link

codecov bot commented Jul 14, 2022 •
edited
Loading

Codecov Report

Merging #1491 (17763b4) into main (4964c8e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1491   +/-   ##
=======================================
  Coverage   85.41%   85.41%           
=======================================
  Files          91       91           
  Lines        8483     8483           
=======================================
  Hits         7246     7246           
  Misses       1237     1237

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4964c8e...17763b4. Read the comment docs.

@kecnry kecnry force-pushed the data-menu-vertical-scroll-fix branch from 97142cb to 17763b4 Compare July 14, 2022 20:08
@kecnry
Copy link
Member Author

kecnry commented Jul 14, 2022

I wasn't sure about the change log since its only a UI annoyance/bug. But I added one just to be safe and will merge once CI passes. Thanks for the quick review!

@kecnry kecnry merged commit d24f823 into spacetelescope:main Jul 15, 2022
@kecnry kecnry deleted the data-menu-vertical-scroll-fix branch July 15, 2022 12:35
@pllim pllim removed the no-changelog-entry-needed changelog bot directive label Jul 15, 2022
@kecnry kecnry mentioned this pull request Jul 20, 2022
Merged
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

@duytnguyendtn duytnguyendtn Awaiting requested review from duytnguyendtn

@rosteen rosteen Awaiting requested review from rosteen rosteen is a code owner

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

@ojustino ojustino Awaiting requested review from ojustino

Assignees
No one assigned
Labels
bug Something isn't working trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
2 participants
@kecnry @pllim